fix: fix flaky tests and add manifest transaction retry#48530
Open
xiaofan-luan wants to merge 3 commits intomilvus-io:masterfrom
Open
fix: fix flaky tests and add manifest transaction retry#48530xiaofan-luan wants to merge 3 commits intomilvus-io:masterfrom
xiaofan-luan wants to merge 3 commits intomilvus-io:masterfrom
Conversation
sre-ci-robot
added
area/test
sig/testing
approved
size/XS
mergify
bot
added
dco-passed
Contributor
|
[ci-v2-notice] To rerun ci-v2 checks, comment with:
If you have any questions or requests, please contact @zhikunyao. |
The test_milvus_client_timestamptz_add_field_with_default_value test was missing a convert_timestamptz() call to normalize expected timestamp values before comparison. This caused flaky failures when CI environments had different tzdata versions or when the server returned timestamps in a slightly different format. All other timestamptz tests already use this normalization pattern. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Cherry-pick PR milvus-io#48463 (fix flaky element_filter_search test) and PR milvus-io#48501 (add configurable retry limit for manifest transaction). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
xiaofan-luan
force-pushed
the
fix-timestamptz-flaky-test
branch
from
5f0381d to
cebd6d7
Compare
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
xiaofan-luan
changed the title
sre-ci-robot
added
size/M
This was referenced Mar 26, 2026
sre-ci-robot
added
the
low-code-coverage
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (73.91%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #48530 +/- ##
==========================================
- Coverage 77.66% 77.62% -0.04%
==========================================
Files 2112 2112
Lines 351497 351515 +18
==========================================
- Hits 272978 272876 -102
- Misses 70201 70296 +95
- Partials 8318 8343 +25
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_element_filter_search_basic_cosineby using distinctive unit vectors (from PR test: fix flaky element_filter_search_basic_cosine test #48463)convert_timestamptzin timestamptz default value testconfigs/milvus.yamlto sync with paramtable changesissue: #48500
Test plan
common.storage.manifestTransactionRetryLimitconfigs/milvus.yamlregenerated and in sync with paramtable🤖 Generated with Claude Code